Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only return EOF when we've read no bytes #62

Closed
Stebalien opened this issue Mar 2, 2022 · 0 comments · Fixed by #64
Closed

Only return EOF when we've read no bytes #62

Stebalien opened this issue Mar 2, 2022 · 0 comments · Fixed by #64

Comments

@Stebalien
Copy link
Collaborator

This was partially addressed in #61 and #60.

Currently, both ScanForLinks and Unmarshal will end up returning EOF instead of ErrUnexpectedEOF in some cases where they've read some data but not all the data. We likely need top-level "if EOF, replace with ErrUnexpectedEOF" guards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return EOF and ErrUnexpectedEOF correctly MarcoPolo/cbor-gen
1 participant
@Stebalien