Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The shared attribute processing steps for iframe and frame elements may invoke iframe load event steps on frame element #8295

Closed
awesomekling opened this issue Sep 19, 2022 · 1 comment
Closed

The shared attribute processing steps for iframe and frame elements may invoke iframe load event steps on frame element #8295

awesomekling opened this issue Sep 19, 2022 · 1 comment
Assignees
@domenic
Labels
topic: browsing context topic: events

Comments

@awesomekling
Copy link
Member

https://html.spec.whatwg.org/multipage/iframe-embed-object.html#shared-attribute-processing-steps-for-iframe-and-frame-elements

In step 4.2. we call out to run iframe load event steps given element, which expects an iframe parameter. However, the element at this point may also be a frame.
@domenic
Copy link
Member

domenic commented Sep 27, 2022

Thanks! I put a fix for this into #6315 since it seemed like the best way to fix this was by a proper refactoring, and I didn't want to do that twice (once before #6315, and once after). See 81cd346

@domenic domenic self-assigned this Sep 27, 2022
@domenic domenic mentioned this issue Sep 27, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
topic: browsing context topic: events
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @awesomekling