Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible defect for method 'expire_view_cache' #1

Open
OshinoMoumou opened this issue Jun 9, 2021 · 0 comments
Open

Possible defect for method 'expire_view_cache' #1

OshinoMoumou opened this issue Jun 9, 2021 · 0 comments

Comments

@OshinoMoumou
Copy link

Greetings!
I noticed that method expire_view_cache referred a StackOverflow post, while a recent comment to it mentioned that if the initial request are made in a different language / different timezone, the key won't match in the cache and you will end up with key = None. One other common issue is the request.META["SERVER_NAME"] being different (eg: 127.0.0.1:8000 vs localhost:80).
I'm trying to learn the usefulness of such small updates on StackOverflow. Would this comment help improve your code? I understand that such defect might not happen in real life situation. In that case, do you think this comment can help prevent future bugs (for example, when the code were reused somewhere else)?
I'll really appreciate it if you could kindly give me some feedback or suggestions. Thank you very much for your time.
Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant