ws does not support multiple paths

[ibc]

var ws = require('ws');
var http = require('http');

var httpServer = http.createServer();
httpServer.listen(10080, '127.0.0.1');

var ws1 = new ws.Server({server:httpServer, path:"/qwe"});
ws1.on('connection', function(){
  console.log("connection on /qwe");
});

var ws2 = new ws.Server({server:httpServer, path:"/asd"});
ws2.on('connection', function(){
  console.log("connection on /asd");
});

OK, now go to a browser (Chrome for example) and open a ws connection to both paths:

CHROME: new WebSocket("ws://local.protoo.org:10080/qwe");
NODE: > connection on /qwe

CHROME: new WebSocket("ws://local.protoo.org:10080/asd");
NODE: > connection on /qwe  <--- same!

And even worst, it behaves wrong after that and does not react on new events, etc. For example try to connect to path "/nonexist" and later again to "/qwe", nothing happens then.

So, is this feature really tested?

[ibc]

Easier: create a http server and a single ws Server with some specific path, and add a log on the 'connection' event.

• Connect from a browser to the correct path. You'll see the log.
• Connect from a browser to any other invalid path. You'll see nothing (because ws does nothing in this case).
• Connect from a browser to the correct path. You'll see nothing!

So, this means that if you set "path" and any client attempts to connect to a different path, then ws stops working forever. Wow. Not, this feature cannot be tested at all.

[ibc]

This is "fixed" (I mean, removed) in my pull request #379.

[ibc]

To be clear. Sharing the same http.Server on two different instances of ws.Server means that the "upgrade" event is called on both, That is a no-go (by testing I've seen even errors in Chrome due to wrong frame received, probably because both ws.Server instances are replying 101, etc.

So, my pull request removes all the path stuff from ws. Instead, the user can inspect the HTTP request in the reqUpgrade field of the ws.WebSocket generated instance, exactly the same he must do when dealing with just http.Server.

[yarax]

Hi! I proposed a pull request #481 for using regexp both with string paths
I hope it would be useful for the issue

[sushantdhiman]

I am having same issue when sharing the WS servers with same express server.

[lpinca]

I agree with @ibc. The feature is kinda broken when using 2+ server that share the same HTTP server.
I've also proposed a PR (#885) to remove the broken feature.

[lpinca]

@ibc I think it has been closed because #885 has been merged.

[ibc]

Nice to know, thanks. So sorry for my comment.

[lpinca]

No problem.