Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

occur error when run some WebSocket Servers. #1122

Closed
youkinjoh opened this issue May 24, 2017 · 2 comments
Closed

occur error when run some WebSocket Servers. #1122

youkinjoh opened this issue May 24, 2017 · 2 comments

Comments

@youkinjoh
Copy link

//package.json
{
  "name": "ws-pullreq",
  "version": "0.0.1",
  "private": true,
  "dependencies": {
    "ws": "3.0.0",
    "express": ">=3.2.0 <4.0.0"
  }
}
//app.js
var express = require('express')
  , http = require('http')
  , WebSocket = require('ws')
  , WebSocketServer = WebSocket.Server;

var app = express();

app.set('port', 3000);

var server = http.createServer(app);

var servers = [];
var clients = [];

console.log(process.env.SWITCH);

switch(process.env.SWITCH) {
  case 'foo':
    servers.push(new WebSocketServer({'server': server, 'path': '/foo'}));
    break;
  case 'bar':
    servers.push(new WebSocketServer({'server': server, 'path': '/bar'}));
    break;
  case 'foobar':
    servers.push(new WebSocketServer({'server': server, 'path': '/foo'}));
    servers.push(new WebSocketServer({'server': server, 'path': '/bar'}));
    break;
}

setTimeout(function() {
  switch(process.env.SWITCH) {
    case 'foo':
      clients.push(new WebSocket('ws://localhost:3000/foo'));
      break;
    case 'bar':
      clients.push(new WebSocket('ws://localhost:3000/bar'));
      break;
    case 'foobar':
      clients.push(new WebSocket('ws://localhost:3000/foo'));
      clients.push(new WebSocket('ws://localhost:3000/bar'));
      break;
  }
  clients.map(function(client, indx, ary) {
    client.on('open', function(e) {
      console.log('--open--');
      console.log(client.url);
    });
    client.on('error', function(err) {
      console.log('--error--');
      console.log(client.url);
      console.log(err.message);
    });
  });
}, 1000);

server.listen(app.get('port'), function() {
  console.log('Express server listening on port ' + app.get('port'));
});

when % SWITCH="foo" node app.js

foo
Express server listening on port 3000
--open--
ws://localhost:3000/foo

when % SWITCH="bar" node app.js

bar
Express server listening on port 3000
--open--
ws://localhost:3000/bar

when % SWITCH="foobar" node app.js

foobar
Express server listening on port 3000
--open--
ws://localhost:3000/foo
--error--
ws://localhost:3000/foo
RSV1 must be clear
--error--
ws://localhost:3000/bar
unexpected server response (400)
@youkinjoh
Copy link
Author

when ws@2.3.1

% SWITCH="foobar" node app.js
foobar
Express server listening on port 3000
--open--
ws://localhost:3000/foo
--error--
ws://localhost:3000/foo
FIN must be set
--error--
ws://localhost:3000/bar
unexpected server response (400)

when ws@1.1.4

% SWITCH="foobar" node app.js
foobar
Express server listening on port 3000
--open--
ws://localhost:3000/foo
--open--
ws://localhost:3000/bar

@lpinca
Copy link
Member

lpinca commented May 24, 2017

See #885.

@lpinca lpinca closed this as completed May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants