-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circular dependencies making knip stuck #749
Labels
bug
Something isn't working
Comments
it-is-required.though |
I will make it in a couple of hours. Sorry i do not have time right now |
No issues here:
|
Hum ... is it relative to Node / OS ? i'm on ProductName: macOS
ProductVersion: 14.5
BuildVersion: 23F79
Node: v20.16.0 Or maybe a root .npmrc which change |
You could try CSB or SB: https://knip.dev/guides/issue-reproduction#templates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction url
https://github.com/blephy/knip-circulare-dep
Description of the issue
Given a mono-repository, if it's contains project which are dependent on each other, knip is running in loop and never failed.
Yes, circular dependencies are bad, but there is some case you cannot do anything about :
Each are requesting each other.
I did manage to bypass this bug by not including in their package.json's devDependencies the package, but instead to rely on a relative import in configs.
instead of :
and
do :
and
The text was updated successfully, but these errors were encountered: