Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Change clientLogLevel order to be called first #1973

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 5, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

maybe related #1972.

before

Screen Shot 2019-06-05 at 16 18 45

after

Screen Shot 2019-06-05 at 16 21 26

Breaking Changes

no

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, one note

lib/Server.js Outdated
if (this.hot) {
this.sockWrite([connection], 'hot');
}

if (this.options.liveReload !== false) {
if (this.options.liveReload) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be breaking change for non boolean value, let's avoid this in this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll change it at next major version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@hiroppy
Copy link
Member Author

hiroppy commented Jun 5, 2019

Sorry, I contained another commit to put .gitkeep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants