Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add callback support for invalidate #1900

Merged
merged 4 commits into from
May 31, 2019

Conversation

EslamHiko
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

add tests for this PR : #1590

Breaking Changes

no

Additional Info

@@ -74,6 +75,51 @@ describe('Server', () => {
});
});

describe('Testing callback functions on calling invalidate without callback', () => {
it('should be `noop` (the default callback function)', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use done because Server.test.js has already used done and can reduce code length.
After all, resolve is called in server.close in the callback, so you don't have to make a Promise.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #1900 into master will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1900      +/-   ##
==========================================
+ Coverage   91.13%   91.49%   +0.35%     
==========================================
  Files          18       18              
  Lines         835      835              
  Branches      262      262              
==========================================
+ Hits          761      764       +3     
+ Misses         70       68       -2     
+ Partials        4        3       -1
Impacted Files Coverage Δ
lib/Server.js 92.22% <100%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca0341...906c2d4. Read the comment docs.

@alexander-akait
Copy link
Member

/cc @hiroppy

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1900 into master will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1900      +/-   ##
==========================================
+ Coverage   91.13%   91.49%   +0.35%     
==========================================
  Files          18       18              
  Lines         835      835              
  Branches      262      262              
==========================================
+ Hits          761      764       +3     
+ Misses         70       68       -2     
+ Partials        4        3       -1
Impacted Files Coverage Δ
lib/Server.js 92.22% <100%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca0341...906c2d4. Read the comment docs.

@alexander-akait alexander-akait merged commit cd218ef into webpack:master May 31, 2019
@alexander-akait
Copy link
Member

Thanks, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants