Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow array for headers option #1042

Merged
merged 4 commits into from
Sep 21, 2021
Merged

feat: allow array for headers option #1042

merged 4 commits into from
Sep 21, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Sep 18, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

allow array for headers option:-

          headers: [
            {
              key: "X-Foo",
              value: "value1",
            },
            {
              key: "X-Bar",
              value: "value2",
            },
          ],

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #1042 (f483475) into master (00eeb6e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   97.37%   97.39%   +0.02%     
==========================================
  Files          10       10              
  Lines         343      346       +3     
  Branches      110      110              
==========================================
+ Hits          334      337       +3     
  Misses          9        9              
Impacted Files Coverage Δ
src/middleware.js 95.34% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00eeb6e...f483475. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's fix lint problems

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update docs too

@alexander-akait alexander-akait merged commit 5a6a3f0 into master Sep 21, 2021
@alexander-akait alexander-akait deleted the array-headers branch September 21, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants