Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

fix(package): add webpack >= v4.0.0 (peerDependencies) #239

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

ai
Copy link
Contributor

@ai ai commented Feb 23, 2018

Oops, I forgot about peerDependencies. Is it correct?

@michael-ciniawsky michael-ciniawsky changed the title fix(package): update webpack peerDependencies fix(package): add webpack >= v4.0.0 (peerDependencies) Feb 23, 2018
@ai
Copy link
Contributor Author

ai commented Feb 23, 2018

@michael-ciniawsky or should I use ^4.0.0-beta.2?

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep :)

⚠️ This will still display a warning until webpack >= v4.0.0 is out of beta

@michael-ciniawsky michael-ciniawsky added this to the 1.2.2 milestone Feb 23, 2018
@michael-ciniawsky michael-ciniawsky merged commit 4c7f80a into webpack-contrib:master Feb 23, 2018
@michael-ciniawsky
Copy link
Member

The webpack 4 release should be around the 24th, better to leave this clean and wait 1-2 days in this case :)

@ai
Copy link
Contributor Author

ai commented Feb 23, 2018

@michael-ciniawsky fixed

@michael-ciniawsky
Copy link
Member

I will release them with the webpack 4 release, which hopefully is within the next 1-2 days as announced. Otherwise I fix/add beta versions as well in meantime I kept a note :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants