fix: error handling #1141
Merged
fix: error handling #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
- Coverage 94.66% 94.03% -0.63%
==========================================
Files 5 5
Lines 375 369 -6
Branches 137 136 -1
==========================================
- Hits 355 347 -8
- Misses 17 19 +2
Partials 3 3
☔ View full report in Codecov by Sentry. |
mischnic
added a commit
to vercel/next.js
that referenced
this pull request
Sep 16, 2024
Bump sass-loader to include webpack-contrib/sass-loader#1141. Closes PACK-2447 Previously sass-loader called `this.async()()` when failing to load the dependency, which meant that the following Webpack loaders still run (because that call is passes `error = undefined` and `content = undefined`). That PR changes it to `this.async()(err)`. This in turn changes the **Turbopack** error message in this case from ``` resolve-url-loader: PostCSS error PostCSS received undefined instead of string ``` to ``` Error evaluating Node.js code Error: Cannot find module 'sass' ``` I upgraded to sass-loader 15 because 16 has a pretty breaking change regarding options: https://github.com/webpack-contrib/sass-loader/releases/tag/v16.0.0 [Breaking sass-loader changes between 12.6.0 and 15.0.0](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md): - 15.0.0 (2024-07-23) - prefer sass-embedded over sass by default - 14.0.0 (2024-01-15) - removed `fibers` support - minimum supported Node.js version is 18.12.0 - 13.0.0 - minimum supported Node.js version is 14.15.0 - emit `@warn` at-rules as webpack warnings by default, if you want to revert behavior please use the warnRuleAsWarning option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Part of webpack/webpack#15980
Breaking Changes
No
Additional Info
No