Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the Premade Shapes feature with adding more out of the box shapes #26

Open
Peshou opened this issue Jul 30, 2018 · 1 comment
Open

Comments

@Peshou
Copy link
Collaborator

Peshou commented Jul 30, 2018

The canvas currently has FreeHand, Line, Rect, Circle, Star (5 spikes), Smile shapes.

It will be good if more shapes are inserted and are available out of the box, and if someone does not want a particular shape he can easily unregister it from the service.

@Peshou Peshou self-assigned this Jul 30, 2018
@Peshou Peshou changed the title Enhance the Shape Selector with adding more out of the box shapes Enhance the Premade Shapes feature with adding more out of the box shapes Jul 30, 2018
@johannesschobel
Copy link

would it be an idea to provide a dedicated ng2-canvas-whiteboard-shape-base repository, which hosts some pre-made shapes?
I am thinking of something like image-packs (i.e., glyphicons, fontawesome, ...). This way, one could easily "switch" the style for pre-made shapes, by including a dedicated package?

For example, if the user wants to have iOS style shapes, he may want to include the ng2-canvas-whiteboard-shape-ios package, for an Android app, you may want to use the ng2-canvas-whiteboard-shape-android package..

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants