Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if this.video is correct #295

Open
kalwalt opened this issue Nov 8, 2022 · 1 comment
Open

Check if this.video is correct #295

kalwalt opened this issue Nov 8, 2022 · 1 comment
Assignees
Labels
question Further information is requested Typescript

Comments

@kalwalt
Copy link
Member

kalwalt commented Nov 8, 2022

Inside the CameraViewRenderer (getImage and image getter) there is a reference to this.video:

this.context_process.drawImage(this.video, 0, 0, this.vw, this.vh, this.ox, this.oy, this.w, this.h);

and:
this.context_process.drawImage(this.video, 0, 0, this.vw, this.vh, this.ox, this.oy, this.w, this.h);

but video is not declared or defined in the class, we have only the _video member:

public _video: HTMLVideoElement;

We need to check the correctness of this and if this may lead to some bugs.

@kalwalt kalwalt added question Further information is requested Typescript labels Nov 8, 2022
@kalwalt kalwalt self-assigned this Nov 8, 2022
@kalwalt kalwalt changed the title check if this.video is correct Check if this.video is correct Nov 8, 2022
@kalwalt
Copy link
Member Author

kalwalt commented Nov 8, 2022

To be clear this.video is the getters defined here

public get video(): HTMLVideoElement {
return this._video;
}

I'm wondering if this make sense or not. Could we get the _video (private) directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Typescript
Projects
None yet
Development

No branches or pull requests

1 participant