feat: add warn when request type bail from "module-import" #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fi3ework
force-pushed
the
module-import
branch
from
6d197bc
to
fbde8ff
Compare
fi3ework
force-pushed
the
module-import
branch
from
fbde8ff
to
0acdcbb
Compare
fi3ework
force-pushed
the
module-import
branch
from
0acdcbb
to
bea70d4
Compare
Timeless0911
approved these changes
Aug 26, 2024
fi3ework
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
requireto load an external module in ESM output, therequirestatement will adopt themoduleexternal type (the behavior of"module-import"external type). However, it can be challenging to identify the desired external type for therequirestatement. As a result, a warning will prompt the user to explicitly specify the correct external type.Related Links
Checklist