Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add support for the metadata service in ignite run #77

Open
luxas opened this issue Jun 18, 2019 · 12 comments
Open

Add support for the metadata service in ignite run #77

luxas opened this issue Jun 18, 2019 · 12 comments
Labels
area/UX Let's make Ignite's UX great! contributor-assigned This issue has been assigned to a contributor kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@luxas
Copy link
Contributor

luxas commented Jun 18, 2019

Firecracker has a metadata service that allows for passing arbitrary JSON data to the VM, where it client-side can be fetched from a hardcoded 169.254.169.254 IP endpoint.

We should allow the user to specify this metadata at runtime.

@luxas luxas added this to the v0.4.0 milestone Jun 18, 2019
@luxas luxas modified the milestones: v0.4.0, v0.5.0 Jun 28, 2019
@patrobinson
Copy link
Contributor

Wouldn't it be better to expose firecracker.sock say at /var/lib/firecracker/vm/$id/firecracker.sock?
This way you could dynamically update the metadata and access other features of the Firecracker API.

@luxas
Copy link
Contributor Author

luxas commented Jul 11, 2019

Yes, that is also a good idea (approved #132 😄), but at VM start time (IIRC), you need to set whether the MMDS should be enabled or not, and by default we have it disabled for less resource usage.
So we'd most probably like to expose some high-level knob to set the data, too

@patrobinson
Copy link
Contributor

@luxas oh cool, I'll work on that next

@luxas
Copy link
Contributor Author

luxas commented Jul 17, 2019

Thank you @patrobinson ✨! Let us know if you need any help.

@luxas luxas added area/UX Let's make Ignite's UX great! contributor-assigned This issue has been assigned to a contributor kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 17, 2019
@luxas
Copy link
Contributor Author

luxas commented Aug 2, 2019

Hi @patrobinson 👋 any progress here? Do you want help on getting this up and running?

@patrobinson
Copy link
Contributor

I had a look at this but it wasn't trivial. It's not currently a focus for me sorry.

@luxas luxas modified the milestones: v0.5.0, Next Aug 6, 2019
@luxas
Copy link
Contributor Author

luxas commented Aug 6, 2019

Ok, no problem. Would you like some smaller work item to help out on @patrobinson instead or are you too busy at the moment?

@patrobinson
Copy link
Contributor

Thanks @luxas for being so forthcoming, but at this stage I'm not looking to actively contribute. That may change in the future and I'll let you know.

@luxas luxas removed the contributor-assigned This issue has been assigned to a contributor label Aug 7, 2019
@luxas
Copy link
Contributor Author

luxas commented Aug 7, 2019

Gotcha. No problem 😄!

@alexeldeib
Copy link
Contributor

@luxas what are you thinking here? user passes in json on vm creation and that gets applied with a PUT after VM is up, or introducing an ignite CLI command to pass through arbitrary data to MMDS? Or something else?

@alexeldeib
Copy link
Contributor

I started on this 😄 Would appreciate guidance though

@luxas
Copy link
Contributor Author

luxas commented Aug 12, 2019

Thanks! I'll comment on the PR 👍

@luxas luxas added the contributor-assigned This issue has been assigned to a contributor label Aug 12, 2019
@luxas luxas modified the milestones: Next, v0.6.0 Aug 12, 2019
@luxas luxas modified the milestones: v0.6.0, Next Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/UX Let's make Ignite's UX great! contributor-assigned This issue has been assigned to a contributor kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants