Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add an internal API group, use that internally #183

Closed
luxas opened this issue Jul 15, 2019 · 1 comment · Fixed by #215
Closed

Add an internal API group, use that internally #183

luxas opened this issue Jul 15, 2019 · 1 comment · Fixed by #215
Assignees
@luxas
Labels
kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.5.0

Comments

@luxas
Copy link
Contributor

luxas commented Jul 15, 2019

The Kubernetes API machinery works by having a set of external versions supported, all converting into the internal API types for internal use. We should follow that pattern.

See https://github.com/luxas/sample-config for sample code of that.
@luxas luxas added this to the v0.5.0 milestone Jul 15, 2019
@luxas luxas added kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 15, 2019
@luxas luxas self-assigned this Jul 15, 2019
@luxas luxas mentioned this issue Jul 18, 2019
Merged
@luxas
Copy link
Contributor Author

luxas commented Jul 18, 2019

Fixed with #215

@luxas luxas closed this as completed Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luxas luxas

Labels
kind/refactor Categorizes issue or PR as related to refactoring code. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Create internal API types, and use them luxas/ignite
1 participant
@luxas