Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about the Observation Encoder #33

Open
wzn0828 opened this issue Oct 20, 2023 · 1 comment
Open

Confused about the Observation Encoder #33

wzn0828 opened this issue Oct 20, 2023 · 1 comment

Comments

@wzn0828
Copy link

wzn0828 commented Oct 20, 2023

Hi,many thanks for your excellent work, Mile.

However, I'm very confused about the Observation Encoder:

In your paper, you described that the observation embedding x_t is the concatenation of the image feature (after pooling to BEV), route map feature and speed feature: x_t = [x_t' , r_t, m_t].
image

That's to say, the order is : pooling to BEV → mapping to a 1D vector → concat route map feature and speed feature

But, in the code, it seems that the order is reversed: concat route map feature and speed feature → pooling to BEV → mapping to a 1D vector. Like the codes in Mile.mile.models.mile.py:
image

Very confused, or am I wrong? pls tell me...

@anthonyhu
Copy link
Collaborator

Good catch, I think in practice this is a technicality that does not matter much (concatenating before of after the BEV backbone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants