Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BrickDimension for iPad. #7

Merged

Conversation

thevwu
Copy link
Contributor

@thevwu thevwu commented Oct 24, 2016

Use UIScreen.mainScreen's traitCollection instead of UIView. UIView is not on view hierarchy at time of call, so the trait collections are all unspecified. This messes up sizing for bricks on iPad.

This commit fixes issue #6

@rubencagnie rubencagnie merged commit 7f57656 into wayfair-archive:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants