Integration with Travis #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are disabling the `expectFatalError` tests because Travis is not handling this correctly
klundberg
approved these changes
Oct 21, 2016
| extension XCTest { | ||
| var is32Bit: Bool { | ||
| let is32bit = sizeof(Int) == sizeof(Int32) | ||
| return is32bit |
There was a problem hiding this comment.
This would be more concise/less repetitive if it was just returning the expression
| @@ -306,7 +314,7 @@ class BrickCollectionViewTests: XCTestCase { | |||
| brickView.layoutSubviews() | |||
|
|
|||
| var cell = brickView.cellForItemAtIndexPath(NSIndexPath(forItem: 0, inSection: 1)) as? CollectionBrickCell | |||
| XCTAssertNil(cell?.frame) | |||
| XCTAssertEqual(cell?.frame.height ?? 0, 0) | |||
There was a problem hiding this comment.
Is the ?? 0 necessary? I though XCTAssertEqual would also compare optional things by default
There was a problem hiding this comment.
You are correct. But because iOS9 and iOS10 have different behaviors, I opted to write a test that works for both. I will add it as a comment
Current coverage is 93.69% (diff: 20.00%)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectFatalErrortests because Travis is not handling this correctly