Updated height provider code to be a closure #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility in specifying a custom height.
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=========================================
Coverage ? 93.41%
=========================================
Files ? 40
Lines ? 4392
Branches ? 359
=========================================
Hits ? 4103
Misses ? 288
Partials ? 1
Continue to review full report at Codecov.
|
jay18001
suggested changes
Sep 27, 2017
| @@ -77,7 +73,7 @@ open class GenericBrickCell: BrickCell { | |||
| } | |||
| } | |||
|
|
|||
| open var customHeightProvider: CustomHeightProvider? | |||
| open var customHeightProvider: ((_ width: CGFloat) -> CGFloat)? | |||
jay18001
approved these changes
Sep 27, 2017
jay18001
changed the title
willspurgeon
pushed a commit
to willspurgeon/brickkit-ios
that referenced
this pull request
Oct 23, 2017
mamccarthy
added a commit
to mamccarthy/brickkit-ios
that referenced
this pull request
Nov 14, 2017
… Edge Insets Functionality Squashed Commit of the following: commit 89ef650 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 9 10:16:10 2017 -0500 Added additional verbose logging to refresh/reloading of data. commit cee70e8 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 2 15:05:39 2017 -0400 Clear prefetch index paths upon invalidation. Written by nlobue commit c760425 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 30 16:50:56 2017 -0400 Fix for a crash that can occur if the first index is greater the number of items. commit a838e8d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 23 14:15:58 2017 -0400 Updated height provider code to be a closure (wayfair-archive#191). Fix by vlozko. commit 5e21936 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Wed Oct 18 14:06:09 2017 -0400 Fix for crash commit 48846ee Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Fri Oct 13 10:04:59 2017 -0400 Attempt to fix a crash commit e6d3c6d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Oct 5 17:28:58 2017 -0400 Added a flag that determines which version of the inset updating code is run.
jay18001
pushed a commit
that referenced
this pull request
Nov 20, 2017
… Edge Insets Functionality (#202) * Stability, Layout, and Logging Enhancements; Added Support for Legacy Edge Insets Functionality Squashed Commit of the following: commit 89ef650 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 9 10:16:10 2017 -0500 Added additional verbose logging to refresh/reloading of data. commit cee70e8 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 2 15:05:39 2017 -0400 Clear prefetch index paths upon invalidation. Written by nlobue commit c760425 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 30 16:50:56 2017 -0400 Fix for a crash that can occur if the first index is greater the number of items. commit a838e8d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 23 14:15:58 2017 -0400 Updated height provider code to be a closure (#191). Fix by vlozko. commit 5e21936 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Wed Oct 18 14:06:09 2017 -0400 Fix for crash commit 48846ee Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Fri Oct 13 10:04:59 2017 -0400 Attempt to fix a crash commit e6d3c6d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Oct 5 17:28:58 2017 -0400 Added a flag that determines which version of the inset updating code is run. * Fix crash when changing repeat counts; Add unit tests for it * Line spacing fix, per PR comment * Replace XCTAssertEqual with XCTAssertEqualWithAccuracy due to Swift version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for more flexibility in specifying a custom height. Also happens to fix a potential memory leak.