Checks if _brick!=nil before calling framesDidLayout(). #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a run-time crash during dequeing a cell while brick hasn’t yet been set. Checks if it’s an AsynchronouseResizableCell before calling layoutIfNeeded during the attribute pass.
ablokker
force-pushed
the
fixFramesDidLayout
branch
from
320a6b3
to
389ef4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 93.37% 93.48% +0.11%
==========================================
Files 39 39
Lines 4149 4160 +11
Branches 339 341 +2
==========================================
+ Hits 3874 3889 +15
+ Misses 274 270 -4
Partials 1 1
Continue to review full report at Codecov.
|
jay18001
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a run-time crash during dequeing a cell while brick hasn’t yet been set. Checks if it’s an AsynchronouseResizableCell before calling layoutIfNeeded during the attribute pass.