Support for ordering bricks within a section #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
Coverage ? 93.42%
=========================================
Files ? 39
Lines ? 3148
Branches ? 0
=========================================
Hits ? 2941
Misses ? 207
Partials ? 0
Continue to review full report at Codecov.
|
Added support to specify which brick is repeated at what index for a section. Say a section has 2 bricks, that are each repeated 5 times. If the `orderDataSource` is set, the implementor needs to specify based on the actual index (IndexPath’s item), which brick and index needs to be returned. This gives full control to the implementor to define the order of the bricks Fixes #139
rubencagnie
force-pushed
the
139-order-bricks
branch
from
a18f5bf
to
9924c6f
Compare
jay18001
suggested changes
Jul 7, 2017
| @@ -49,7 +49,7 @@ extension BrickSection { | |||
| return brickSection.numberOfBricks(in: collection) | |||
| } | |||
|
|
|||
| internal func brickAndIndex(at indexPath: IndexPath, in collection: CollectionInfo) -> (Brick, Int)? { | |||
| internal func brickAndIndex(atIndexPath indexPath: IndexPath, in collection: CollectionInfo) -> (Brick, Int)? { | |||
There was a problem hiding this comment.
Can we use just do brickAndIndex(at indexPath: IndexPath, ...
There was a problem hiding this comment.
there is also a func brickAndIndex(atIndex brickIndex: Int, in collection: CollectionInfo) -> (Brick, Int)?, so the atIndexPath is to make the difference
jay18001
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to specify which brick is repeated at what index for a section.
Say a section has 2 bricks, that are each repeated 5 times. If the
orderDataSourceis set, the implementor needs to specify based on the actual index (IndexPath’s item), which brick and index needs to be returned. This gives full control to the implementor to define the order of the bricksFixes #139