Move image brick delegate change over to swift 3 branch #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## swift3 #107 +/- ##
=========================================
Coverage ? 93.03%
=========================================
Files ? 38
Lines ? 3031
Branches ? 0
=========================================
Hits ? 2820
Misses ? 211
Partials ? 0
Continue to review full report at Codecov.
|
jay18001
reviewed
Mar 14, 2017
Source/Bricks/Image/ImageBrick.swift
Outdated
| @@ -217,6 +199,11 @@ open class ImageBrickCell: GenericBrickCell, Bricklike, AsynchronousResizableCel | |||
| self.imageDownloader?.downloadImageAndSet(on: self.imageView, with: imageURL, onCompletion: { (image, url) in | |||
| self.imageLoaded = true | |||
| self.resize(image: image) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Can you remove some of this white space
nick-lobue
force-pushed
the
imagebrick_delegate
branch
from
155096a
to
3c0a6fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.