Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix flaky connectedness test #657

Closed
chaitanyaprem opened this issue Aug 21, 2023 · 1 comment
Closed

bug: Fix flaky connectedness test #657

chaitanyaprem opened this issue Aug 21, 2023 · 1 comment
Labels
bug Something isn't working E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details test Issue related to the test suite with no expected consequence to production code

Comments

@chaitanyaprem
Copy link
Collaborator

Describe the bug
The test TestConnectionStatusChanges under waku/v2/node is flaky and randomly keeps failing.

2023-08-21T10:46:24.975+0530 INFO gowaku.node2.connection-notifier node/connectedness.go:70 peer connected {"peer": "16Uiu2HAmS3gToFFpevWgFLi2inLFAn1kD8YVH2xHJbHKdsacDw2Z", "direction": "Inbound"}
--- FAIL: TestConnectionStatusChanges (0.04s)
connectedness_test.go:34:
Error Trace: /Users/prem/Code/go-waku/waku/v2/node/connectedness_test.go:34
/usr/local/go/src/runtime/asm_arm64.s:1172
Error: "[]" should have 1 item(s), but has 0
Test: TestConnectionStatusChanges

To Reproduce
Run make test a few times and we can notice that the TestConnectionStatusChanges test keeps failing randomly.

Expected behavior
No flaky tests as it gives a bad devEx.

Screenshots

go-waku version/commit hash

gowaku version 0.7.0-8a9c4d6

@chaitanyaprem chaitanyaprem changed the title bug: Fix flaky node connectedness test bug: Fix flaky connectedness test Aug 21, 2023
@fryorcraken fryorcraken added test Issue related to the test suite with no expected consequence to production code E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details and removed E:2023-qa labels Sep 22, 2023
@chaitanyaprem chaitanyaprem added the help wanted Extra attention is needed label Dec 5, 2023
@chair28980 chair28980 added the bug Something isn't working label Jan 2, 2024
@chair28980 chair28980 removed the help wanted Extra attention is needed label Feb 6, 2024
@richard-ramos
Copy link
Member

Closing as this issue rarely appears on CI, and it does not affect functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details test Issue related to the test suite with no expected consequence to production code
Projects
Status: Done
Development

No branches or pull requests

4 participants