Adding protocolhandlers #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a reference to the step in the algorithm that defines the registration of protocol handlers in the HTML spec.
Ran the doc through tidy html and added a couple of references to the scheme and url members of the registerProtocolHandler method.
marcoscaceres
requested changes
Apr 14, 2021
There was a problem hiding this comment.
Thanks for taking first stab at this @diekus.
Few things: we've dropped IDL from the spec, so be good to update to match the updated style. Similarly, we don't have "issue a developer warning" anymore.
There also need to be some strong security assurances around those URL replacements. It might be worth looking at how Web Share Target handles that (or perhaps some other specs that do something similar).
| <li>Let <var>url</var> be <var>protocol_handler.url</var>. | ||
| </li> | ||
| <li>Replace the first occurrence of the exact literal string "%s" in | ||
| <var>url</var> with an escaped version of the absolute URL. |
There was a problem hiding this comment.
The "an escaped version" needs some definition (or link to) of how to do the escaping.
|
I'm closing this PR since I've noticed how far behind it is and it's simpler to branch from the current state of main for now and apply the new changes there.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #863
This change (choose at least one, delete ones that don't apply):
Implementation commitment (delete if not making normative changes):
If change is normative, and it adds or changes a member:
Commit message:
Adds "protocol_handlers" member to the manifest spec, referencing the process that navigator.registerProtocolHandler uses.
contributors:
+@fabiorocha
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
Preview | Diff