Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): ensure app instance can be garbage collected after unmount (close #2907) #2909

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Dec 29, 2020

When unmounting an app, we need to remove the __vue_app__ property from the container element, otherwise the app instance can't be garbage collected for as long as that element exists.

closes #2907

@LinusBorg LinusBorg force-pushed the linusborg/fix-app-unmount-memleak-2907 branch from 7de02b1 to d5d7c79 Compare December 29, 2020 12:55
@LinusBorg LinusBorg changed the title fix(runtime-core): ensure app instance can be gargabe collected after unmount fix(runtime-core): ensure app instance can be gargabe collected after unmount (close #2907) Dec 29, 2020
@LinusBorg LinusBorg added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Dec 29, 2020
@github-actions
Copy link

github-actions bot commented Dec 29, 2020

Size report

Path Size
vue.global.prod.js 40.52 KB (+0.03% 🔺)
runtime-dom.global.prod.js 26.84 KB (+0.04% 🔺)
size-check.global.prod.js 16.21 KB (+0.04% 🔺)

@LinusBorg LinusBorg requested a review from Akryum January 6, 2021 09:57
@LinusBorg
Copy link
Member Author

@Akryum Tagged you for a review as that hook is for devtools. I think it's safe to remove it here. Agree?

@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Feb 1, 2021
@LinusBorg LinusBorg changed the title fix(runtime-core): ensure app instance can be gargabe collected after unmount (close #2907) fix(runtime-core): ensure app instance can be garbage collected after unmount (close #2907) Feb 3, 2021
@LinusBorg LinusBorg merged commit 60e05ef into master Feb 3, 2021
@LinusBorg LinusBorg deleted the linusborg/fix-app-unmount-memleak-2907 branch February 3, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.unmount() memory leak
2 participants