v4: mark useEventHook param as not optional #1027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useEventHook
param is currently marked optional.This disables the possibility to destructure the query/mutation results directly in the callback parameter.
For example:
would currently yield a typescript error:
(note the
| undefined
also the event is declared asconst resultEvent = useEventHook<ApolloQueryResult<any>>()
)This PR solves the issue.
It is safe because:
trigger
is called with an undefined value (at least not in a way allowed by the type system)useEventHook<Param | undefined>()