Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apollo-composable] Multiple ApolloClients don't work #1023

Closed
liaoliaojun opened this issue Jul 29, 2020 · 3 comments
Closed

[apollo-composable] Multiple ApolloClients don't work #1023

liaoliaojun opened this issue Jul 29, 2020 · 3 comments
Labels

Comments

@liaoliaojun
Copy link

Describe the bug
resolveClient should has argument clientId #906

function resolveClient code:

function resolveClient() {
    if (clientId) {
      resolveClientWithId(providedApolloClients, clientId)
    }
    return resolveDefaultClient(providedApolloClients, providedApolloClient)
 }

useQuery.ts:

 const { resolveClient } = useApolloClient()
 const client = resolveClient(currentOptions.value.clientId)

To Reproduce
Steps to reproduce the behavior:
Use apollo-composable provide Multiple ApolloClients.

Expected behavior
work

Versions
@vue/composition-api:1.0.0-beta.6
@vue/apollo-composable:v4.0.0-alpha.10
@apollo-boost:0.4.7

Additional context

liaoliaojun added a commit to liaoliaojun/vue-apollo that referenced this issue Jul 29, 2020
@liaoliaojun liaoliaojun changed the title [apollo-composable] Multiple ApolloClients no work [apollo-composable] Multiple ApolloClients don't work Jul 30, 2020
@nicolaiunrein
Copy link

Same issue here. Seems that using anything but the default client breaks.

@AntonnyAGS
Copy link

Any update about it? Same issue here

@jakedohm
Copy link

@Akryum I'm hitting this exact issue, where specifying clientId doesn't do anything. I'm updated to the latest versions, I believe, has this fix been released yet? If not, would it be possible to include it in a release/patch soon, or let me know how to update my project to get this fix.

Thanks!

PS: Amazing work on this, it's SOO good to work with ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants