fix: compare serialized variables to prevent unnecessary fetch

vuejs · Jan 22, 2020 · 3a473e2 · 3a473e2
1 parent 32d1f75
commit 3a473e2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/packages/vue-apollo-composable/src/useQuery.ts b/packages/vue-apollo-composable/src/useQuery.ts
@@ -323,9 +323,14 @@ export function useQuery<
 
   // Applying variables
   let currentVariables: TVariables
-  watch(variablesRef, value => {
-    currentVariables = value
-    restart()
+  let currentVariablesSerialized: string
+  watch(variablesRef, (value, oldValue) => {
+    const serialized = JSON.stringify(value)
+    if (serialized !== currentVariablesSerialized) {
+      currentVariables = value
+      restart()
+    }
+    currentVariablesSerialized = serialized
   }, {
     deep: true,
   })

diff --git a/packages/vue-apollo-composable/src/useSubscription.ts b/packages/vue-apollo-composable/src/useSubscription.ts
@@ -211,9 +211,14 @@ export function useSubscription <
 
   // Applying variables
   let currentVariables: TVariables
-  watch(variablesRef, value => {
-    currentVariables = value
-    restart()
+  let currentVariablesSerialized: string
+  watch(variablesRef, (value, oldValue) => {
+    const serialized = JSON.stringify(value)
+    if (serialized !== currentVariablesSerialized) {
+      currentVariables = value
+      restart()
+    }
+    currentVariablesSerialized = serialized
   }, {
     deep: true,
   })