Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE junit tests -> build with acceptance tests #140

Closed
bytesandwich opened this issue Apr 27, 2013 · 5 comments
Closed

PDE junit tests -> build with acceptance tests #140

bytesandwich opened this issue Apr 27, 2013 · 5 comments

Comments

@bytesandwich
Copy link

eclipse is suggesting to me to run junit plugin tests

A brief google search turns up a possible test configuration

I think tests would give the project a breath of fresh air towards a vigorous future.

@bytesandwich
Copy link
Author

I'm looking at groovy-eclipse : /org.eclipse.jdt.groovy.core.tests.builder/src/org/eclipse/jdt/core/groovy/tests/builder/BasicGroovyBuildTests.java

I think that's a pretty good starting point to work from.

@FagnerMartinsBrack
Copy link

So the plugin does not have test right now, right?
I never developed an eclipse plugin but I have a suggestion that may work (or not, cause no research has been made on it).

In order to avoid regression, mainly for syntax issues, you should create a test project with a bunch of less files splitted into a structured system. It may hold regular tests for complicated treatments and issue specific ones.
Such project could be pushed to the git repo, then developers may create failing cases without having to go deep into the development for one or two issues.

Example:
TestProject/issues/44.less
TestProject/issues/45.less
TestProject/issues/45.less
TestProject/tests/syntax-x.less
TestProject/tests/feature-y.less

I am not sure if the deployment is fast enough to allow running all tests for each small modification, but at least it could help to avoid regression for each release without messing with junit, mockito, etc.

@vtst
Is this possible?
This is the only eclipse less plugin out there, but fails a lot for the most important project in the web, Twitter Bootstrap.

@vtst vtst closed this as completed Apr 20, 2014
@paulvi
Copy link

paulvi commented Apr 21, 2014

@jackphel @FagnerMartinsBrack Would you write test case for framework of your interest?

Having coverage test to catch regressions like #188 make sense, when CI is present #206

@FagnerMartinsBrack
Copy link

I would have done that at the time I posted this (or at least helped to do so). Right now it is not feasible due to the fact I am drowned in 2 projects.

I am not sure if this issue was closed because it will not be done or because it will be done, another issue requesting documentation for contributing was closed too, so I suppose the author is not willing to implement this.

@paulvi
Copy link

paulvi commented Apr 23, 2014

Yep, the author is [yet] not social enough for such great open-source undertaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants