Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a 'firewalld_direct_purge' resource to the catalog hangs rspec-puppet #205

Closed
trevor-vaughan opened this issue Sep 18, 2019 · 4 comments

Comments

@trevor-vaughan
Copy link
Collaborator

Unsure of details beyond that honestly and couldn't exactly figure out where it was hanging.

I did note that there are tests for it in the main firewalld spec tests so it may be something in my setup.

@trevor-vaughan
Copy link
Collaborator Author

So, it turns out that something is trying to run real firewall-cmd commands when testing this resource. This seems like a bug given that basic resource creation shouldn't do anything on the system if properly encapsulated as a Type.

@alexjfisher
Copy link
Member

I've noticed this when running onceover (which compiles role classes). In my gnome environment I always get a dialog popping up asking me for the root password. If I cancel it, everything continues normally. If you can figure out how to stop this, that'd be amazing.

@trevor-vaughan
Copy link
Collaborator Author

The test will either have to stub the appropriate calls or the type will need to be updated (if possible) to not go poking around until it hits the provider (preferred).

Will probably have time to look at Pupptize (along with refactoring around the SERVER-94 issue)

@trevor-vaughan
Copy link
Collaborator Author

Closing. This was identified as #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants