Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README for consul::service is out of date #110

Closed
zxjinn opened this issue Apr 19, 2015 · 1 comment · Fixed by #112
Closed

README for consul::service is out of date #110

zxjinn opened this issue Apr 19, 2015 · 1 comment · Fixed by #112

Comments

@zxjinn
Copy link
Contributor

zxjinn commented Apr 19, 2015

In the README the Service Definition section code example looks like it's showing an older way of configuration. The redis example should look like so:

  ::consul::service { 'redis':
    checks  => [
      { 
        script   => "/usr/local/bin/check_redis.py",
        interval => "10s"
      }
    ],
    port    => 8000,
    tags    => ['master']
  }

Just like my other issue I just made, I'm more than willing to submit a PR if you don't want to do the legwork.

@solarkennedy
Copy link
Contributor

Yes please, I would love a PR on a README refresh.
If you are in there, feel free to address #97 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants