Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to access cities database #70

Closed
vnegi10 opened this issue Jan 1, 2024 · 0 comments · Fixed by #72
Closed

Unable to access cities database #70

vnegi10 opened this issue Jan 1, 2024 · 0 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@vnegi10
Copy link
Owner

vnegi10 commented Jan 1, 2024 •
edited
Loading

The following error has been appearing since last few days. It seems the CSV file is not accessible anymore via the GeoNames_analysis repository.

julia> @time using WeatherReport
ERROR: LoadError: Unable to load cities database, check if https://github.com/vnegi10/GeoNames_analysis/master/cities500_lat_long.csv is accessible!
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] url_to_df(url::String)
    @ WeatherReport ~/.julia/packages/WeatherReport/4QTIq/src/helpers.jl:38

Possible solutions:

  • Make the CSV file part of WeatherReport.jl if it's not too big
  • Host the file on Storj
  • Fetch the city based on a given lat/long also via the OpenMeteo API
@vnegi10 vnegi10 added the bug Something isn't working label Jan 1, 2024
@vnegi10 vnegi10 linked a pull request Jan 2, 2024 that will close this issue
70 fix cities database #72
Merged
@vnegi10 vnegi10 mentioned this issue Jan 2, 2024
Merged
vnegi10 referenced this issue Jan 2, 2024
@vnegi10
70 fix cities database (#72)
f8055a6 
* Add CSV file and update file logic

* Update DF_CITIES

* Fix syntax

* Update relevant tests

* Update ref. data for failing tests

* Bump version

* Add issue details to README
vnegi10 referenced this issue Jan 3, 2024
@vnegi10
73 fix air quality metrics (#74)
71df46c 
* Filter response dict

* Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

70 fix cities database vnegi10/WeatherReport.jl
1 participant
@vnegi10