-
Notifications
You must be signed in to change notification settings - Fork 95
Conversation
Fixes #2074 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please merge after getting the CI green and addressing a minor comment.
esx_service/vmdk_ops.py
Outdated
# Fix up the KV for the destination | ||
# Clone creates side cars with a random key and hence filename | ||
# which need more work to figure out and use each time a volume | ||
# op is performed. Remove the side car that hte clone created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: hte
=> the
@shuklanirdesh82, the build seems to fail with all products VDVS, vFile and Windows, with error Problem accessing /job/VDVS%20Multibranch%20Pipeline%20-%20Temp/job/PR-2077/1/display/redirect. Reason: Anyway I can restart the build |
@ashahi1 can you please take a look at this CI failure? |
#2077 (comment) |
All tests passed with latest changes. Test results:
|
From ESX 6.5 onwards, the sidecars for the clone destination get created with a random key vs. the key thats used to create the source sidecars. Which is why the ESX service was unable to open and read/write the file after clone. Effectively clone was broken in 6.5 and later.
Fixed and now able to clone volumes fine.
docker volume ls
DRIVER VOLUME NAME
vsphere:latest test@datastore1
docker volume create -d vsphere clone -o clone-from=test
clone
docker volume inspect clone
[
{
"Driver": "vsphere:latest",
"Labels": {},
"Mountpoint": "/mnt/vmdk/clone/",
"Name": "clone",
"Options": {
"clone-from": "test"
},
"Scope": "global",
"Status": {
"access": "read-write",
"attach-as": "independent_persistent",
"capacity": {
"allocated": "13MB",
"size": "100MB"
},
"clone-from": "test",
"created": "Sun Mar 18 19:28:08 2018",
"created by VM": "ubuntu-VM2.3 (1)",
"datastore": "datastore1",
"diskformat": "thin",
"fstype": "ext4",
"status": "detached"
}
}
]