Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Adds Microsoft/go-winio vendor package #1473

Merged

Conversation

venilnoronha
Copy link
Contributor

This commit adds the Microsoft/go-winio vendor package, which will be used for implementing the npipe based Docker plugin on windows.

I'm skipping the test here as there is no direct code change, and this addition was already validated in PR #1447.

This commit adds the Microsoft/go-winio vendor package, which will be
used for implementing npipe based Docker plugin on Windows.
Copy link
Contributor

@msterin msterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only bring go-winio and does not touch anything else, right ? LGTM them

@venilnoronha
Copy link
Contributor Author

@msterin that's right.

Copy link
Contributor

@pshahzeb pshahzeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@venilnoronha venilnoronha merged commit 4196f1f into vmware-archive:master Jun 26, 2017
shuklanirdesh82 pushed a commit that referenced this pull request Jun 29, 2017
[CI SKIP] Known issue doc.liping (#1475)

* Add known issue in README.md. [SKIP CI]

Adds Microsoft/go-winio vendor package (#1473)

This commit adds the Microsoft/go-winio vendor package, which will be used for implementing the npipe based Docker plugin for Windows.

Creates platform specific config and main modules (#1482)

This commit separates platform specific config and plugin serving code from the generic one. It will aid development of the Windows plugin.

* Extracts unix sock service from main.go into main_linux.go.
* Moves linux specific config from config.go into config_linux.go.
* Renames config_test.go to config_linux_test.go.

Adding a test for delete/recreate default vm group & fix cleanup in vmdk_ops_test.py (#1381)

Log cleanup for VMListener : VM object not found (#1489)

Update CONTRIBUTING.md

Refreshing test setup requirement and bring contributing.md to current.

[SKIP CI] Addressing Sam's comment

revamping contributing.md

Addressing Mark's comment

Update CONTRIBUTING.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants