This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing VIB on ESXi 5.5 generates the error: VIB VMWare_bootbank_esx-vmdkops-service_0.14.0577889-0.0.1 requires esx-version >= 6.0.0 However, this version requirement isnt documented. Just like he Docker version is called out, it would be beneficial to call out that the ESXi version should be 6.0 or higher.
@nnf97, VMware has approved your signed contributor license agreement. |
Good catch. Looks like README calls out ESX versions but documentation doesn't. @shuklanirdesh82 Should ESX and Docker version be part of prerequisite.md |
pdhamdhere
approved these changes
Jun 12, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Yeah, I will add such information. Thanks @nnf97 for catching! |
shuklanirdesh82
approved these changes
Jun 12, 2017
Right. I saw that on the readme. However, it phrases it as 'tested on', which to my mind means, it is possible that this thing will work on other versions, but no one had the time or resources to actually test it on the other versions.
The error message clearly says it should be ESXi 6.0 as the lowest version.
I will update the readme as well to indicate that 6.0 and up is a 'requirement', if you don't mind.
On Jun 12, 2017, at 5:28 PM, Prashant Dhamdhere <notifications@github.com<mailto:notifications@github.com>> wrote:
Good catch. Looks like README<https://github.com/vmware/docker-volume-vsphere/blob/master/README.md> calls out ESX versions but documentation doesn't.
@shuklanirdesh82<https://github.com/shuklanirdesh82> Should ESX and Docker version be part of prerequisite.md<https://github.com/vmware/docker-volume-vsphere/edit/gh-pages/jekyll-docs//prerequisite.md>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1392 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFDVaD9p2Rz-mt9_MIfSotKzkzo8vy9mks5sDa2LgaJpZM4N3X2N>.
|
@nnf97 Correct. Anything below ESXi 6.0 is not supported.
Sure thing and thanks in advance, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing VIB on ESXi 5.5 generates the error: VIB VMWare_bootbank_esx-vmdkops-service_0.14.0577889-0.0.1 requires esx-version >= 6.0.0
However, this version requirement isnt documented. Just like he Docker version is called out, it would be beneficial to call out that the ESXi version should be 6.0 or higher.