Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Introducing common e2e test utils #1320

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Introducing common e2e test utils #1320

merged 1 commit into from
Jun 1, 2017

Conversation

pshahzeb
Copy link
Contributor

@pshahzeb pshahzeb commented Jun 1, 2017

This PR is a subset of PR #1299. This only includes changes for common test utils.

  1. govc utils for datastores and related constants
  2. volume read/write utils
  3. volume create with options util
  4. admincli util to create a policy and update volume access

Testing: e2e-test target passes locally.

1. govc utils for datastores and related constants
2. volume read/write utils
3. volume create with options util
4. admincli util to create a policy and update volume access
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for breaking down.

Copy link
Contributor

@shaominchen shaominchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pshahzeb
Copy link
Contributor Author

pshahzeb commented Jun 1, 2017

@govint I am merging this PR with common utils. Should any need arise to further improve them, we can accommodate it in further PRs.

@pshahzeb pshahzeb merged commit c366017 into master Jun 1, 2017
@pshahzeb pshahzeb deleted the test_utils.pshahzeb branch June 13, 2017 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants