Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

[Automation] Replacing []byte return type with string for test utils #1290

Merged
merged 2 commits into from
May 24, 2017

Conversation

pshahzeb
Copy link
Contributor

@pshahzeb pshahzeb commented May 24, 2017

Quick refactoring to change return type of utils from []byte to string so that we avoid conversions else where in the tests
Testing:
test-all target passes locally.
The end output of test-all target

PASS
coverage: 40.6% of statements

exact test output of e2e-test

=== RUN   Test
2017/05/24 04:40:48 START: basic-test.TestVolumeIsolation
2017/05/24 04:40:48 Creating volume [basic_test_volume_1495600848] on VM [10.192.33.29]
2017/05/24 04:40:50 Checking volume [basic_test_volume_1495600848] availability from VM [10.192.33.29]
2017/05/24 04:40:51 Checking volume [basic_test_volume_1495600848] availability from VM [10.192.33.29]
2017/05/24 04:40:52 Destroying volume [basic_test_volume_1495600848]
2017/05/24 04:40:52 END: basic-test.TestVolumeIsolation
2017/05/24 04:40:52 START: basic-test.TestVolumeLifecycle
2017/05/24 04:40:52 Creating volume [basic_test_volume_1495600852] on VM [10.192.33.29]
2017/05/24 04:40:54 Checking volume [basic_test_volume_1495600852] availability from VM [10.192.33.29]
2017/05/24 04:40:55 Attaching volume [basic_test_volume_1495600852] on VM [10.192.33.29]
2017/05/24 04:40:57 Confirming attached status for volume [basic_test_volume_1495600852]
2017/05/24 04:40:59 Removing container [basic_test_container_1495600852] on VM [10.192.33.29]
2017/05/24 04:41:00 Confirming detached status for volume [basic_test_volume_1495600852]
2017/05/24 04:41:03 Destroying volume [basic_test_volume_1495600852]
2017/05/24 04:41:03 Checking volume [basic_test_volume_1495600852] availability from VM [10.192.33.29]
2017/05/24 04:41:04 Creating volume [basic_test_volume_1495600852] on VM [10.192.33.29]
2017/05/24 04:41:06 Checking volume [basic_test_volume_1495600852] availability from VM [10.192.33.29]
2017/05/24 04:41:07 Attaching volume [basic_test_volume_1495600852] on VM [10.192.33.29]
2017/05/24 04:41:08 Confirming attached status for volume [basic_test_volume_1495600852]
2017/05/24 04:41:10 Removing container [basic_test_container_1495600852] on VM [10.192.33.29]
2017/05/24 04:41:11 Confirming detached status for volume [basic_test_volume_1495600852]
2017/05/24 04:41:14 Destroying volume [basic_test_volume_1495600852]
2017/05/24 04:41:15 Checking volume [basic_test_volume_1495600852] availability from VM [10.192.33.29]
2017/05/24 04:41:16 END: basic-test.TestVolumeLifecycle
2017/05/24 04:41:16 Creating volume [restart_test_volume_1495600876] on VM [10.192.33.29]
2017/05/24 04:41:18 START: restart_test.TestPluginKill
2017/05/24 04:41:18 Attaching volume [restart_test_volume_1495600876] on VM[10.192.33.29]
2017/05/24 04:41:19 Confirming attached status for volume [restart_test_volume_1495600876]
2017/05/24 04:41:21 Killing vDVS plugin on VM [10.192.33.29]
2017/05/24 04:41:23 Sleep for 2 seconds
2017/05/24 04:41:25 Stopping container [restart_test_container_1495600876] on VM [10.192.33.29]
2017/05/24 04:41:37 Starting container [restart_test_container_1495600876] on VM [10.192.33.29]
2017/05/24 04:41:38 Stopping container [restart_test_container_1495600876] on VM [10.192.33.29]
2017/05/24 04:41:49 Confirming detached status for volume [restart_test_volume_1495600876]
2017/05/24 04:41:52 END: restart_test.TestPluginKill
2017/05/24 04:41:52 Removing container [restart_test_container_1495600876] on VM [10.192.33.29]
2017/05/24 04:41:52 Destroying volume [restart_test_volume_1495600876]
2017/05/24 04:41:53 Creating volume [restart_test_volume_1495600913] on VM [10.192.33.29]
2017/05/24 04:41:55 START: restart_test.TestVolumeStaleMount
2017/05/24 04:41:55 Attaching volume [restart_test_volume_1495600913] on VM [10.192.33.29]
2017/05/24 04:41:57 Confirming attached status for volume [restart_test_volume_1495600913]
2017/05/24 04:41:59 Killing docker on VM [10.192.33.29]
2017/05/24 04:41:59 Sleep for 2 seconds
2017/05/24 04:42:01 Confirming detached status for volume [restart_test_volume_1495600913]
2017/05/24 04:42:25 END: restart_test.TestVolumeStaleMount
2017/05/24 04:42:25 Removing container [restart_test_container_1495600913] on VM [10.192.33.29]
2017/05/24 04:42:26 Destroying volume [restart_test_volume_1495600913]
2017/05/24 04:42:27 Finding VM name from IP Address [10.192.33.29]
2017/05/24 04:42:28 START: Test vmdkops service restart + kill vm process
2017/05/24 04:42:28 Creating volume [vmlistener_test_volume_1495600948] on VM [10.192.33.29]
2017/05/24 04:42:30 Attaching volume [vmlistener_test_volume_1495600948] on VM [10.192.33.29]
2017/05/24 04:42:32 Confirming attached status for volume [vmlistener_test_volume_1495600948]
2017/05/24 04:42:34 Restarting vmdkops service on ESX host [10.192.35.13]
2017/05/24 04:42:37 Confirming attached status for volume [vmlistener_test_volume_1495600948]
2017/05/24 04:42:40 Retrieving VM power state for [ubuntu-VM0.0]
2017/05/24 04:42:41 VM[ubuntu-VM0.0]'s current power state is [poweredOn]
2017/05/24 04:42:41 Retrieving World ID for VM [ubuntu-VM0.0] from ESX [10.192.35.13]
2017/05/24 04:42:42 VM's process ID is: 1961726
2017/05/24 04:42:42 Killing VM from ESX [10.192.35.13]
2017/05/24 04:42:43 Sleep for 10 seconds
2017/05/24 04:42:53 Retrieving VM power state for [ubuntu-VM0.0]
2017/05/24 04:42:54 VM[ubuntu-VM0.0]'s current power state is [poweredOff]
2017/05/24 04:42:55 Powering on VM [ubuntu-VM0.0]
2017/05/24 04:42:57 Sleep for 35 seconds
2017/05/24 04:43:32 Retrieving VM power state for [ubuntu-VM0.0]
2017/05/24 04:43:33 VM[ubuntu-VM0.0]'s current power state is [poweredOn]
2017/05/24 04:43:33 Confirming detached status for volume [vmlistener_test_volume_1495600948]
2017/05/24 04:43:36 END: Test vmdkops service restart + kill vm process
2017/05/24 04:43:36 Destroying volume [vmlistener_test_volume_1495600948]
OK: 5 passed
--- PASS: Test (169.48s)

Copy link
Contributor

@shaominchen shaominchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@shuklanirdesh82 shuklanirdesh82 merged commit 9945e92 into master May 24, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the issue_1289.pshahzeb branch May 24, 2017 20:24
@shuklanirdesh82
Copy link
Contributor

fixed #1289

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants