This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Introducing test constants into separate files #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaominchen
reviewed
May 17, 2017
tests/constants/dockercli/cmd.go
Outdated
| ListVolumes = dockerVol + "ls " | ||
|
|
||
| // Inspect to grab volume properties | ||
| Inspect = dockerVol + "inspect " |
There was a problem hiding this comment.
Inspect => InspectVolume
tests/constants/dockercli/cmd.go
Outdated
| Inspect = dockerVol + "inspect " | ||
|
|
||
| // Remove constant refers delete volume command | ||
| Remove = dockerVol + "rm " |
There was a problem hiding this comment.
Remove => RemoveVolume
| package dockercli | ||
|
|
||
| const ( | ||
| docker = "docker " |
There was a problem hiding this comment.
Nit: why these 2 names start with small case?
There was a problem hiding this comment.
kept it private members ... no need to export them
There was a problem hiding this comment.
Then above VmdkopsAdmin and VmdkopsAdminVolume should not be exported either.
There was a problem hiding this comment.
Agree, updating into the next diff.
shuklanirdesh82
force-pushed
the
testConstants.shuklanirdesh82
branch
from
f531dd1
to
c7aaf54
Compare
shuklanirdesh82
force-pushed
the
testConstants.shuklanirdesh82
branch
from
c7aaf54
to
066a779
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1271
Testing done: Yes locally