Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Adding gocheck test framework support (Issue #472) #1246

Merged

Conversation

shuklanirdesh82
Copy link
Contributor

Please refer #472 (comment) for more information.

Testing done: locally with sample testcase

sample output for passed test:

nshukla-mbp:docker-volume-vsphere nshukla$ make e2e-test 
/Library/Developer/CommandLineTools/usr/bin/make --directory=vmdk_plugin e2e-test
Makefile:154: warning: overriding commands for target `clean'
../plugin/Makefile:87: warning: ignoring old commands for target `clean'

=> Running target e2e-test Fri May 12 20:57:54 PDT 2017

../misc/scripts/build.sh e2e-dkrVolDriver-test "10.20.105.97" "10.20.104.62" "10.20.104.62"
Makefile:154: warning: overriding commands for target `clean'
../plugin/Makefile:87: warning: ignoring old commands for target `clean'
make: Entering directory `/go/src/github.com/vmware/docker-volume-vsphere/vmdk_plugin'

=> Running target e2e-dkrVolDriver-test Sat May 13 03:57:55 UTC 2017

GO15VENDOREXPERIMENT=1 go test github.com/vmware/docker-volume-vsphere/tests/e2e -v
=== RUN   Test
OK: 1 passed
--- PASS: Test (0.00s)
PASS
ok  	github.com/vmware/docker-volume-vsphere/tests/e2e	0.006s
make: Leaving directory `/go/src/github.com/vmware/docker-volume-vsphere/vmdk_plugin'

sample output for failed test:

nshukla-mbp:docker-volume-vsphere nshukla$ vi tests/e2e/hello_test.go 
nshukla-mbp:docker-volume-vsphere nshukla$ make e2e-test 
/Library/Developer/CommandLineTools/usr/bin/make --directory=vmdk_plugin e2e-test
Makefile:154: warning: overriding commands for target `clean'
../plugin/Makefile:87: warning: ignoring old commands for target `clean'

=> Running target e2e-test Fri May 12 20:59:51 PDT 2017

../misc/scripts/build.sh e2e-dkrVolDriver-test "10.20.105.97" "10.20.104.62" "10.20.104.62"
Makefile:154: warning: overriding commands for target `clean'
../plugin/Makefile:87: warning: ignoring old commands for target `clean'
make: Entering directory `/go/src/github.com/vmware/docker-volume-vsphere/vmdk_plugin'

=> Running target e2e-dkrVolDriver-test Sat May 13 03:59:52 UTC 2017

GO15VENDOREXPERIMENT=1 go test github.com/vmware/docker-volume-vsphere/tests/e2e -v
=== RUN   Test

----------------------------------------------------------------------
FAIL: hello_test.go:17: MySuite.TestHelloWorld

hello_test.go:18:
    c.Assert(42, Equals, "42")
... obtained int = 42
... expected string = "42"

--- FAIL: Test (0.00s)
OOPS: 0 passed, 1 FAILED
FAIL
exit status 1
FAIL	github.com/vmware/docker-volume-vsphere/tests/e2e	0.007s
make: *** [e2e-dkrVolDriver-test] Error 1
make: Leaving directory `/go/src/github.com/vmware/docker-volume-vsphere/vmdk_plugin'
make[1]: *** [e2e-test] Error 2
make: *** [e2e-test] Error 2

@shuklanirdesh82
Copy link
Contributor Author

Sample test case has been added to check on CI .. Once testing is done, sample testcase will be removed before merging.

Copy link
Contributor

@shaominchen shaominchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shuklanirdesh82
Copy link
Contributor Author

sample test is removed and waiting for CI to pass before merging.

@shuklanirdesh82 shuklanirdesh82 merged commit 40eec29 into vmware-archive:master May 15, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the gocheck.shuklanirdesh82 branch May 15, 2017 19:32
@shuklanirdesh82 shuklanirdesh82 mentioned this pull request May 16, 2017
7 tasks
@shuklanirdesh82 shuklanirdesh82 removed this from the 0.15 milestone May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants