basic_test.go:TestVmGroupVolumeIsolation() should use physical datastore name

[govint]

The TestVmGroupVolumeIsolation() test creates a volume (which lands on the default DS) and checks for accessibility. The volume is accessible.

Then a new vmgroup is created with VM_DS as the default datastore. Again the volume accessibility is checked.

Its entirely possible that the volume created earlier is in the datastore that VM_DS refers to. A subsequent check on accessibility succeeds, while expecting failure.

The test should check what datastore is actually backing VM_DS in the DEFAULT vmgroup then pick another datastore and create the vmgroup with that.

The test logs from https://ci.vmware.run/vmware/docker-volume-vsphere/775 -

2017/06/28 12:22:19 Creating volume [BasicTestSuite.TestVmGroupVolumeIsolation_volume_134801] on VM [192.168.31.81]
2017/06/28 12:22:26 Checking volume [BasicTestSuite.TestVmGroupVolumeIsolation_volume_134801] availability from VM [192.168.31.81]
2017/06/28 12:22:26 Checking volume [BasicTestSuite.TestVmGroupVolumeIsolation_volume_134801] availability from VM [192.168.31.85]
2017/06/28 12:22:27 Creating a vmgroup [T1] on esx [192.168.31.62]
2017/06/28 12:22:29 Checking volume [BasicTestSuite.TestVmGroupVolumeIsolation_volume_134801] availability from VM [192.168.31.81]

FAIL: basic_test.go:159: BasicTestSuite.TestVmGroupVolumeIsolation

basic_test.go:180:
c.Assert(accessible, Equals, false, Commentf("Volume %s is still available on [%s]", s.volName1, s.vm1))
obtained bool = true
expected bool = false
Volume BasicTestSuite.TestVmGroupVolumeIsolation_volume_134801 is still available on [192.168.31.81]

[govint]

Closing for now, may have been caused by debug code in this CI.