Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

integrate tests package to perform code quality checks #1267

Closed
2 tasks done
shuklanirdesh82 opened this issue May 16, 2017 · 0 comments
Closed
2 tasks done

integrate tests package to perform code quality checks #1267

shuklanirdesh82 opened this issue May 16, 2017 · 0 comments
Assignees
Milestone

Comments

@shuklanirdesh82
Copy link
Contributor

shuklanirdesh82 commented May 16, 2017

integrate tests package to perform code quality checks ... currently test scripts and common utils are not as per the standard.

Two tasks

make: Entering directory `/go/src/github.com/vmware/docker-volume-vsphere/vmdk_plugin'
../tests/e2e/volumepropverification_test.go:36:19: should omit type string from declaration of var esx; it will be inferred from the right-hand side
../tests/e2e/volumepropverification_test.go:40:2: var vmIp should be vmIP
../tests/e2e/volumepropverification_test.go:40:28: should drop = "" from declaration of var vmIp; it is the zero value
../tests/e2e/volumepropverification_test.go:41:19: should omit type string from declaration of var dockerVolmRmvCmd; it will be inferred from the right-hand side
../tests/e2e/volumepropverification_test.go:43:28: should drop = "" from declaration of var containerName; it is the zero value
../tests/utils/dockercli/volumelifecycle.go:27:5: don't use ALL_CAPS in Go names; use CamelCase
../tests/utils/dockercli/volumelifecycle.go:27:5: exported var SSH_OPTS should have comment or be unexported
../tests/utils/dockercli/volumelifecycle.go:27:14: should omit type []string from declaration of var SSH_OPTS; it will be inferred from the right-hand side
../tests/utils/dockercli/volumelifecycle.go:29:1: comment on exported function CreateDefaultVolume should be of the form "CreateDefaultVolume ..."
../tests/utils/dockercli/volumelifecycle.go:36:1: comment on exported function DeleteVolume should be of the form "DeleteVolume ..."
../tests/utils/dockercli/volumelifecycle.go:42:1: comment on exported function InvokeCommand should be of the form "InvokeCommand ..."
../tests/utils/inputparams/testparams.go:39:1: exported function GetVolumeName should have comment or be unexported
../tests/utils/inputparams/testparams.go:43:1: exported function GetVolumeNameWithTimeStamp should have comment or be unexported
../tests/utils/inputparams/testparams.go:47:1: exported function GetEndPoint1 should have comment or be unexported
../tests/utils/inputparams/testparams.go:51:1: exported function GetEndPoint2 should have comment or be unexported
../tests/utils/verification/volumeproperties.go:27:5: don't use ALL_CAPS in Go names; use CamelCase
../tests/utils/verification/volumeproperties.go:27:5: exported var ADMIN_CLI_LS should have comment or be unexported
../tests/utils/verification/volumeproperties.go:28:5: don't use ALL_CAPS in Go names; use CamelCase
../tests/utils/verification/volumeproperties.go:28:5: exported var DOCKER_CLI_INSPC should have comment or be unexported
../tests/utils/verification/volumeproperties.go:30:1: comment on exported function GetVmAttachedToVolUsingDockerCli should be of the form "GetVmAttachedToVolUsingDockerCli ..."
../tests/utils/verification/volumeproperties.go:31:6: func GetVmAttachedToVolUsingDockerCli should be GetVMAttachedToVolUsingDockerCli
../tests/utils/verification/volumeproperties.go:40:1: comment on exported function GetVmAttachedToVolUsingAdminCli should be of the form "GetVmAttachedToVolUsingAdminCli ..."
../tests/utils/verification/volumeproperties.go:41:6: func GetVmAttachedToVolUsingAdminCli should be GetVMAttachedToVolUsingAdminCli
../tests/utils/verification/volumeproperties.go:55:1: comment on exported function GetVolumePropertiesAdminCli should be of the form "GetVolumePropertiesAdminCli ..."
../tests/utils/verification/volumeproperties.go:70:1: comment on exported function GetVolumePropertiesDockerCli should be of the form "GetVolumePropertiesDockerCli ..."
../tests/utils/verification/volumeproperties.go:93:1: comment on exported function GetDockerVersion should be of the form "GetDockerVersion ..."
../tests/utils/verification/volumeproperties.go:100:1: comment on exported function ExecCmd should be of the form "ExecCmd ..."
../tests/utils/verification/volumeproperties.go:110:1: comment on exported function IsDockerCliCheckNeeded should be of the form "IsDockerCliCheckNeeded ..."

/CC @tusharnt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant