You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
CI returns success while in the beginning it gave this warning:
$ make -s build
drivers/shared/etcdops.go:89:39: exported func NewKvStore returns unexported type *shared.etcdKVS, which can be annoying to use
warning: no packages being tested depend on github.com/vmware/docker-volume-vsphere/client_plugin/drivers/shared
warning: no packages being tested depend on github.com/vmware/docker-volume-vsphere/client_plugin/shared_plugin
Is it possible to fail CI if there is a warning?
And regarding to this warning, it will be gone when we finish the refactoring of the shared plugin.
Hey @luomiao, our build script is not strict for golint or pylint warnings/errors due to time constraints and we have an issue open to make python code to compliant with pylint warning. Post vmworld it is possible to restrict the build incase of such warning till then we have to look manually while proposing the new code change.
It will be great if you can supply a quick fix or include any of your ongoing PR to turn off such warning. Since #1661 merged all our builds are having such warning.
#1661 introduces following,
make build
is also complaining about the same./CC @tusharnt
The text was updated successfully, but these errors were encountered: