Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Fix Heroku deploy script #466

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

seadowg
Copy link
Contributor

@seadowg seadowg commented Feb 20, 2023

This updates the Heroku deploy script, so it works with the recent changes to Heroku's pricing plan (free tier add-ons are no longer supported). I've also fixed the custom buildpack/stack combo that was causing problems during deployment.

  • I have reviewed the contributing guide

  • I have made this pull request to the master branch

  • I have run all the tests using ./test.sh.

  • I have added the copyright headers to each new file added

  • I have given myself credit in the humans.txt file (assuming I want to)

@seadowg
Copy link
Contributor Author

seadowg commented Feb 20, 2023

It seems like ./test.sh is broken (on master). Running it in the dev docker image, I get:

rake aborted!
Errno::ENOSYS: Function not implemented - Failed to initialize inotify
/postfacto/api/config/environment.rb:35:in `<top (required)>'
/root/.rbenv/versions/2.7.3/bin/bundle:23:in `load'
/root/.rbenv/versions/2.7.3/bin/bundle:23:in `<main>'
Tasks: TOP => db:create => db:load_config => environment
(See full trace by running task with --trace)

cp -r deployment/upgrade-tkg.sh package/tkg/upgrade.sh
cp -r deployment/mixpanel.sh package/tkg/mixpanel.sh
chmod u+x package/tkg/*.sh
if [ -d deployment/helm/postfacto-*.tgz ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like package.sh requires extra steps to create assets for TGZ deployment. I tried mimicking the steps that Github Actions performs, but it seems like that is no longer working (I run into problems at "Helm build").

I propose that we let packaging work without TGZ, until package.sh can perform can take care of it without extra steps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant