Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add extra noise #2584

Closed
RGX650 opened this issue Dec 3, 2023 · 4 comments
Closed

[Feature]: add extra noise #2584

RGX650 opened this issue Dec 3, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@RGX650
Copy link

RGX650 commented Dec 3, 2023

Feature description

Add noisy latent to ExtraNoiseParams for callback
AUTOMATIC1111/stable-diffusion-webui#12856

Add extra noise callback
AUTOMATIC1111/stable-diffusion-webui#12616

Add extra noise param for img2img operations
AUTOMATIC1111/stable-diffusion-webui#12564

[catboxanon]
https://gist.github.com/catboxanon)/[zz_extra_noise_mask.py]
https://gist.github.com/catboxanon/69ce64e0389fa803d26dc59bb444af53

Version Platform Description

No response

@RGX650 RGX650 added the enhancement New feature or request label Dec 3, 2023
@vladmandic
Copy link
Owner

i'm ok with this, but can you submit actual PR?

@RGX650
Copy link
Author

RGX650 commented Dec 19, 2023

thanks for your interest and reply!

I am not a proper dev actually, git related methodologies an subtilities are still a bit obscure to me...
so please don't be mad at me.

i kind of manage to start implementing it through my fork
https://github.com/RGX650/sd-webui-bmab-SDNEXT/blob/main/README.md
https://github.com/RGX650/sd-webui-bmab-SDNEXT

It is a fork of @portu-sim BMAB extention working with A1111
https://github.com/portu-sim/sd-webui-bmab

Adding A1111's RNG
https://github.com/RGX650/sd-webui-bmab-SDNEXT/tree/main/sd_bmab/external/rng

Adding extra-noise callbacks
RGX650/sd-webui-bmab-SDNEXT@09d9aec
https://github.com/RGX650/sd-webui-bmab-SDNEXT/blob/main/sd_bmab/sd_override/__init__.py

shared.opts.add_option('img2img_extra_noise'
shared.opts.add_option('randn_source'
https://github.com/RGX650/sd-webui-bmab-SDNEXT/blob/main/sd_bmab/ui.py
synch extra-noise value bmab/webui? #1172

class StableDiffusionProcessingTxt2ImgOv(StableDiffusionProcessingTxt2Img)
https://github.com/RGX650/sd-webui-bmab-SDNEXT/blob/main/sd_bmab/sd_override/txt2img.py

class KDiffusionSamplerBMAB(KDiffusionSampler)
https://github.com/RGX650/sd-webui-bmab-SDNEXT/blob/main/sd_bmab/sd_override/samper.py

@vladmandic
Copy link
Owner

I am not a proper dev actually, git related methodologies an subtilities are still a bit obscure to me...
so please don't be mad at me.

mad? far from it - i appreciate the work!

i'll check out your repo soon, really want to wrap-up work on new control module.
also, i will need to implement callback for diffusers backend (where callbacks work quite differently) - but it should be doable.
with more and more features in diffusers backend, i think there will be even more value there.

@vladmandic
Copy link
Owner

sorry for the delay, last month has been pretty crazy.
anyhow, img2img_extra_noise is now added for backend:original k-diffusers. if there is sufficient demand, it can be added to remaining compvis samplers (ddim,unipc). backend:diffusers will need separate implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants