-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more c++ #7
Comments
There is far too many things here (in my opinion) dumped into one patch, and you have changed the formatting of every line of code. It doesn't seem possible to unpick things from this! Some minor comments:
|
Other issues: at() / operator[] return a null if the object being dereferences is not an array, or for out-of-bounds. It seems more 'gason' to assert if we try to dereference something which is not an array. |
chris;
|
The main problem with the whitespace changes is that is makes it very difficult to see what changes you have made, as when I run the code through a differ it says everything has changed! I'll try looking at disabling white-space only changes. |
If you happen to be a vim user, use the diffopt option of vimdiff to hide whitespace only changes. |
dear vivkin;
I enjoyed your parser a lot esp for its low memory footprint.
To mold the api into more c++ (i don't mean std::) and give the end-user even more simple API I've made some small changes in gason to form gason++
gason
namespacebecause these changes breaks your API (just
using namespace gason;
should be added to legacy codes) I prefer not to fork and submit an immediate pull request.but if you find these changes useful please merge them into gason:
https://github.com/azadkuh/gason++
The text was updated successfully, but these errors were encountered: