Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move snapshot port into standalone module #3016

Closed
4 tasks done
christian-bromann opened this issue Mar 16, 2023 · 1 comment · Fixed by #3032
Closed
4 tasks done

Move snapshot port into standalone module #3016

christian-bromann opened this issue Mar 16, 2023 · 1 comment · Fixed by #3032
Labels
enhancement New feature or request

Comments

@christian-bromann
Copy link
Contributor

Clear and concise description of the problem

Hey 👋

I wonder what do you all think of moving the snapshot port from Jest into an own module for other frameworks to consume. I am maintaining the WebdriverIO project and looking to support snapshot tests for unit and component testing in the browser. From what I can see skimming through the code, next to some utils the only module that is shared is the rpc handler which could be passed into the SnapshotManager and other classes that need it. I am not too familiar with the code base, so I could be totally wrong 🤔

Suggested solution

Move snapshot utility into a standalone module for other test frameworks, e.g. WebdriverIO to consume.

Alternative

An alternative is to just copy the code from this repo into the WebdriverIO project, however this would require double maintenance of the same code. Both project have the same requirements to snapshot testing, so why not maintain a single library for it.

Additional context

I am happy to step in and do the necessary work to ship this.

Validations

@christian-bromann
Copy link
Contributor Author

This is amazing @sheremet-va , thank you so much! 🙏

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants