Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-vite): update reference to volar vscode extension #7994

Merged
merged 2 commits into from
May 2, 2022
Merged

chore(create-vite): update reference to volar vscode extension #7994

merged 2 commits into from
May 2, 2022

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented May 2, 2022

Description

When scaffolding a new project with npm create vite@latest my-vue-app -- --template vue-ts or npm create vite@latest my-vue-app -- --template vue, opening the project within Visual Studio Code will trigger the following warning because the namespace for the Volar extension moved from johnsoncodehk.volar to Vue.volar. This PR updates the reference to fix the issue. It also updates the references in the README files.

Screenshot 2022-05-02 at 20 10 56

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@nhedger nhedger marked this pull request as draft May 2, 2022 18:19
@nhedger nhedger marked this pull request as ready for review May 2, 2022 18:23
@patak-dev patak-dev merged commit 2b6d8fe into vitejs:main May 2, 2022
@nhedger nhedger deleted the chore/update-recommended-extension branch May 2, 2022 18:37
@nhedger nhedger restored the chore/update-recommended-extension branch May 2, 2022 18:39
@nhedger nhedger deleted the chore/update-recommended-extension branch May 2, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants