Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust vue template sourcemap #6972

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

Demivan
Copy link
Contributor

@Demivan Demivan commented Feb 18, 2022

Description

Vue template sourcemaps were off by one line. This fixes Vue template coverage in Vitest.

Fixes vitest-dev/vitest#751

Sourcemap before:

before

Sourcemap after:

after

Vitest coverage before:

image

Vitest coverage after:

vitest-fixed

Additional context

Code is being concatenated using newlines here:

let resolvedCode = output.join('\n')

So need to adjust sourcemaps by one line too.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

antfu
antfu previously approved these changes Feb 18, 2022
@patak-dev patak-dev merged commit a774303 into vitejs:main Feb 18, 2022
@Demivan Demivan deleted the vue-template-coverage branch February 18, 2022 14:00
sxzz added a commit to unplugin/unplugin-vue that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add C8 Coverage support for Vue template logic
4 participants