-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove some any
#547
Merged
Merged
fix: remove some any
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Secrets | 0 0 0 0 | View in Orca |
LuciNyan
force-pushed
the
fix-type-any
branch
from
September 20, 2023 03:12
3f7b6e8
to
3a0c81c
Compare
LGTM |
|
🎉 This PR is included in version 0.10.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sahithyandev
pushed a commit
to sahithyandev/satori
that referenced
this pull request
Apr 26, 2024
## Description There are many uses of `any` throughout the codebase. We could aim to tighten up the typings to be more precise. This PR makes only small improvements, but please share any thoughts on further changes we could make or naming conventions to standardize on. I want you to know that all feedback is welcome. <3 @Jackie1210 @shuding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are many uses of
any
throughout the codebase. We could aim to tighten up the typings to be more precise. This PR makes only small improvements, but please share any thoughts on further changes we could make or naming conventions to standardize on. I want you to know that all feedback is welcome. <3@Jackie1210 @shuding.