Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove some any #547

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: remove some any #547

merged 1 commit into from
Sep 20, 2023

Conversation

LuciNyan
Copy link
Contributor

@LuciNyan LuciNyan commented Sep 20, 2023

Description

There are many uses of any throughout the codebase. We could aim to tighten up the typings to be more precise. This PR makes only small improvements, but please share any thoughts on further changes we could make or naming conventions to standardize on. I want you to know that all feedback is welcome. <3

@Jackie1210 @shuding.

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 3:13am

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@LuciNyan LuciNyan marked this pull request as ready for review September 20, 2023 03:26
@LuciNyan LuciNyan changed the title fix: remove some any fix: remove some any Sep 20, 2023
@Jackie1210
Copy link
Contributor

LGTM

@shuding shuding merged commit f68206e into vercel:main Sep 20, 2023
16 checks passed
@shuding
Copy link
Member

shuding commented Sep 20, 2023

:thank-u:

@github-actions
Copy link

🎉 This PR is included in version 0.10.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

sahithyandev pushed a commit to sahithyandev/satori that referenced this pull request Apr 26, 2024
## Description
There are many uses of `any` throughout the codebase. We could aim to
tighten up the typings to be more precise. This PR makes only small
improvements, but please share any thoughts on further changes we could
make or naming conventions to standardize on. I want you to know that
all feedback is welcome. <3

@Jackie1210 @shuding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants